From 5bbceeac9ac675627cacd75bae6c7a74321a5bfe Mon Sep 17 00:00:00 2001 From: Craig Williams Date: Tue, 6 Jun 2023 15:10:02 +0100 Subject: [PATCH] Change table template hierarchy structure --- .../deleted_organisations-actions.html.twig} | 8 +- .../deleted_organisations-info.html.twig} | 8 +- .../organisation_members-actions.html.twig | 54 ++++++++++++ .../organisation_members-info.html.twig} | 10 +-- .../organisation_members-status.html.twig} | 8 +- .../columns/organisations-actions.html.twig | 74 ++++++++++++++++ .../organisations-admin_count.html.twig | 9 ++ .../organisations-description.html.twig | 1 + .../columns/organisations-info.html.twig | 17 ++++ .../columns/organisations-join.html.twig | 27 ++++++ .../organisations-member_count.html.twig | 9 ++ .../columns/organisations-status.html.twig | 25 ++++++ .../users-actions.html.twig} | 8 +- .../users-organisations.html.twig} | 8 +- .../tables/deleted-organisations.html.twig | 13 ++- .../tables/organisation-members.html.twig | 18 ++-- templates/tables/organisations.html.twig | 60 +++++++------ .../column-actions.html.twig | 56 ------------ .../organisations/column-actions.html.twig | 86 ------------------- .../column-admin_count.html.twig | 11 --- .../column-description.html.twig | 9 -- .../organisations/column-info.html.twig | 19 ---- .../organisations/column-join.html.twig | 27 ------ .../column-member_count.html.twig | 11 --- .../organisations/column-status.html.twig | 25 ------ templates/tables/users.html.twig | 10 ++- 26 files changed, 296 insertions(+), 315 deletions(-) rename templates/tables/{partials/deleted-organisations/column-actions.html.twig => columns/deleted_organisations-actions.html.twig} (90%) rename templates/tables/{partials/deleted-organisations/column-info.html.twig => columns/deleted_organisations-info.html.twig} (69%) create mode 100644 templates/tables/columns/organisation_members-actions.html.twig rename templates/tables/{partials/organisation-members/column-info.html.twig => columns/organisation_members-info.html.twig} (74%) rename templates/tables/{partials/organisation-members/column-status.html.twig => columns/organisation_members-status.html.twig} (86%) create mode 100644 templates/tables/columns/organisations-actions.html.twig create mode 100644 templates/tables/columns/organisations-admin_count.html.twig create mode 100644 templates/tables/columns/organisations-description.html.twig create mode 100644 templates/tables/columns/organisations-info.html.twig create mode 100644 templates/tables/columns/organisations-join.html.twig create mode 100644 templates/tables/columns/organisations-member_count.html.twig create mode 100644 templates/tables/columns/organisations-status.html.twig rename templates/tables/{partials/users/column-actions.html.twig => columns/users-actions.html.twig} (96%) rename templates/tables/{partials/users/column-organisations.html.twig => columns/users-organisations.html.twig} (90%) delete mode 100644 templates/tables/partials/organisation-members/column-actions.html.twig delete mode 100644 templates/tables/partials/organisations/column-actions.html.twig delete mode 100644 templates/tables/partials/organisations/column-admin_count.html.twig delete mode 100644 templates/tables/partials/organisations/column-description.html.twig delete mode 100644 templates/tables/partials/organisations/column-info.html.twig delete mode 100644 templates/tables/partials/organisations/column-join.html.twig delete mode 100644 templates/tables/partials/organisations/column-member_count.html.twig delete mode 100644 templates/tables/partials/organisations/column-status.html.twig diff --git a/templates/tables/partials/deleted-organisations/column-actions.html.twig b/templates/tables/columns/deleted_organisations-actions.html.twig similarity index 90% rename from templates/tables/partials/deleted-organisations/column-actions.html.twig rename to templates/tables/columns/deleted_organisations-actions.html.twig index 7398f17..1dac4ad 100644 --- a/templates/tables/partials/deleted-organisations/column-actions.html.twig +++ b/templates/tables/columns/deleted_organisations-actions.html.twig @@ -1,6 +1,5 @@ -{% block table_cell_template_actions %} -{% endblock %} \ No newline at end of file + {% endverbatim %} + \ No newline at end of file diff --git a/templates/tables/partials/deleted-organisations/column-info.html.twig b/templates/tables/columns/deleted_organisations-info.html.twig similarity index 69% rename from templates/tables/partials/deleted-organisations/column-info.html.twig rename to templates/tables/columns/deleted_organisations-info.html.twig index b1ae03d..68d1a9c 100644 --- a/templates/tables/partials/deleted-organisations/column-info.html.twig +++ b/templates/tables/columns/deleted_organisations-info.html.twig @@ -1,11 +1,9 @@ -{% block table_cell_template_info %} -{% endblock %} \ No newline at end of file + {% endverbatim %} + \ No newline at end of file diff --git a/templates/tables/columns/organisation_members-actions.html.twig b/templates/tables/columns/organisation_members-actions.html.twig new file mode 100644 index 0000000..d59866f --- /dev/null +++ b/templates/tables/columns/organisation_members-actions.html.twig @@ -0,0 +1,54 @@ + \ No newline at end of file diff --git a/templates/tables/partials/organisation-members/column-info.html.twig b/templates/tables/columns/organisation_members-info.html.twig similarity index 74% rename from templates/tables/partials/organisation-members/column-info.html.twig rename to templates/tables/columns/organisation_members-info.html.twig index b219ef7..1cb777d 100644 --- a/templates/tables/partials/organisation-members/column-info.html.twig +++ b/templates/tables/columns/organisation_members-info.html.twig @@ -1,10 +1,11 @@ -{% block table_cell_template_info %} -{% endblock %} \ No newline at end of file + {% endverbatim %} + \ No newline at end of file diff --git a/templates/tables/partials/organisation-members/column-status.html.twig b/templates/tables/columns/organisation_members-status.html.twig similarity index 86% rename from templates/tables/partials/organisation-members/column-status.html.twig rename to templates/tables/columns/organisation_members-status.html.twig index f81009b..f961f4a 100644 --- a/templates/tables/partials/organisation-members/column-status.html.twig +++ b/templates/tables/columns/organisation_members-status.html.twig @@ -1,6 +1,5 @@ -{% block table_cell_template_status %} -{% endblock %} \ No newline at end of file + {% endverbatim %} + \ No newline at end of file diff --git a/templates/tables/columns/organisations-actions.html.twig b/templates/tables/columns/organisations-actions.html.twig new file mode 100644 index 0000000..d14cb80 --- /dev/null +++ b/templates/tables/columns/organisations-actions.html.twig @@ -0,0 +1,74 @@ + \ No newline at end of file diff --git a/templates/tables/columns/organisations-admin_count.html.twig b/templates/tables/columns/organisations-admin_count.html.twig new file mode 100644 index 0000000..3b39d93 --- /dev/null +++ b/templates/tables/columns/organisations-admin_count.html.twig @@ -0,0 +1,9 @@ + \ No newline at end of file diff --git a/templates/tables/columns/organisations-description.html.twig b/templates/tables/columns/organisations-description.html.twig new file mode 100644 index 0000000..f04e7f0 --- /dev/null +++ b/templates/tables/columns/organisations-description.html.twig @@ -0,0 +1 @@ +{% include "@uf-tweaks/tables/columns/abstract/description.html.twig" %} \ No newline at end of file diff --git a/templates/tables/columns/organisations-info.html.twig b/templates/tables/columns/organisations-info.html.twig new file mode 100644 index 0000000..a458b46 --- /dev/null +++ b/templates/tables/columns/organisations-info.html.twig @@ -0,0 +1,17 @@ + \ No newline at end of file diff --git a/templates/tables/columns/organisations-join.html.twig b/templates/tables/columns/organisations-join.html.twig new file mode 100644 index 0000000..987e94a --- /dev/null +++ b/templates/tables/columns/organisations-join.html.twig @@ -0,0 +1,27 @@ + \ No newline at end of file diff --git a/templates/tables/columns/organisations-member_count.html.twig b/templates/tables/columns/organisations-member_count.html.twig new file mode 100644 index 0000000..77dee5b --- /dev/null +++ b/templates/tables/columns/organisations-member_count.html.twig @@ -0,0 +1,9 @@ + \ No newline at end of file diff --git a/templates/tables/columns/organisations-status.html.twig b/templates/tables/columns/organisations-status.html.twig new file mode 100644 index 0000000..5ce72b7 --- /dev/null +++ b/templates/tables/columns/organisations-status.html.twig @@ -0,0 +1,25 @@ + \ No newline at end of file diff --git a/templates/tables/partials/users/column-actions.html.twig b/templates/tables/columns/users-actions.html.twig similarity index 96% rename from templates/tables/partials/users/column-actions.html.twig rename to templates/tables/columns/users-actions.html.twig index 180cb7a..6e6c101 100644 --- a/templates/tables/partials/users/column-actions.html.twig +++ b/templates/tables/columns/users-actions.html.twig @@ -1,6 +1,5 @@ -{% block table_cell_template_actions %} -{% endblock %} \ No newline at end of file + {% endverbatim %} + \ No newline at end of file diff --git a/templates/tables/partials/users/column-organisations.html.twig b/templates/tables/columns/users-organisations.html.twig similarity index 90% rename from templates/tables/partials/users/column-organisations.html.twig rename to templates/tables/columns/users-organisations.html.twig index f6f63d8..8bf1900 100644 --- a/templates/tables/partials/users/column-organisations.html.twig +++ b/templates/tables/columns/users-organisations.html.twig @@ -1,6 +1,5 @@ -{% block table_cell_template_organisations %} -{% endblock %} \ No newline at end of file + {% endverbatim %} + \ No newline at end of file diff --git a/templates/tables/deleted-organisations.html.twig b/templates/tables/deleted-organisations.html.twig index 5657bdd..23f616f 100644 --- a/templates/tables/deleted-organisations.html.twig +++ b/templates/tables/deleted-organisations.html.twig @@ -1,8 +1,5 @@ {% extends "tables/organisations.html.twig" %} -{% use 'tables/partials/deleted-organisations/column-info.html.twig' %} -{% use 'tables/partials/deleted-organisations/column-actions.html.twig' %} - {% block table %} @@ -20,4 +17,12 @@
{% endblock %} -{% block table_cell_template_join %}{% endblock %} \ No newline at end of file +{% block table_organisations_column_info %} + {% include 'tables/columns/deleted_organisations-info.html.twig' %} +{% endblock %} + +{% block table_organisations_column_actions %} + {% include 'tables/columns/deleted_organisations-actions.html.twig' %} +{% endblock %} + +{% block table_organisations_column_join %}{% endblock %} \ No newline at end of file diff --git a/templates/tables/organisation-members.html.twig b/templates/tables/organisation-members.html.twig index e6c2af2..0cba587 100644 --- a/templates/tables/organisation-members.html.twig +++ b/templates/tables/organisation-members.html.twig @@ -1,9 +1,5 @@ {% extends "tables/users.html.twig" %} -{% use 'tables/partials/organisation-members/column-info.html.twig' %} -{% use 'tables/partials/organisation-members/column-status.html.twig' %} -{% use 'tables/partials/organisation-members/column-actions.html.twig' %} - {% block table %} @@ -11,7 +7,7 @@ {% if 'last_activity' in table.columns %} - + {% endif %} {% if checkAccess('update_organisation_field', { 'organisation': organisation, 'fields': [ 'members' ] }) or isOrganisationAdmin(organisation) %} @@ -22,4 +18,16 @@
{{translate('USER')}} {{translate("ORGANISATION", 2)}}{{translate("ACTIVITY.LAST")}} {{translate("ACTIVITY.LAST")}} {{translate("STATUS")}}
+{% endblock %} + +{% block table_users_column_info %} + {% include 'tables/columns/organisation_members-info.html.twig' %} +{% endblock %} + +{% block table_users_column_status %} + {% include 'tables/columns/organisation_members-status.html.twig' %} +{% endblock %} + +{% block table_users_column_actions %} + {% include 'tables/columns/organisation_members-actions.html.twig' %} {% endblock %} \ No newline at end of file diff --git a/templates/tables/organisations.html.twig b/templates/tables/organisations.html.twig index 8886c2e..147d044 100644 --- a/templates/tables/organisations.html.twig +++ b/templates/tables/organisations.html.twig @@ -7,36 +7,26 @@ {% extends "tables/table-paginated.html.twig" %} -{% use 'tables/partials/organisations/column-info.html.twig' %} -{% use 'tables/partials/organisations/column-description.html.twig' %} -{% use 'tables/partials/organisations/column-status.html.twig' %} -{% use 'tables/partials/organisations/column-member_count.html.twig' %} -{% use 'tables/partials/organisations/column-admin_count.html.twig' %} -{% use 'tables/partials/organisations/column-join.html.twig' %} -{% use 'tables/partials/organisations/column-actions.html.twig' %} - {% block table %} - {% if 'description' not in table.hidden_columns %} - + {% if 'description' in table.columns %} + + {% endif %} + {% if 'status' in table.columns %} + + {% endif %} + {% if checkAccess('view_organisation_members') %} + + {% endif %} - {% if hasRole('site-admin') or hasRole('organisations-admin') or (current_user.adminForOrganisations.count > 0) -%} - - {% endif -%} - {% if checkAccess('view_organisation_members') -%} - - - {% endif -%} {% if 'join' in table.columns %} - + {% endif %} {% if 'actions' in table.columns %} - {% if hasRole('site-admin') or hasRole('organisations-admin') or (current_user.adminForOrganisations.count > 0) -%} - - {% endif -%} + {% endif %} @@ -46,13 +36,27 @@ {% endblock %} {% block table_cell_templates %} - {{ block('table_cell_template_info') }} - {{ block('table_cell_template_description') }} - {{ block('table_cell_template_status') }} - {{ block('table_cell_template_member_count') }} - {{ block('table_cell_template_admin_count') }} - {{ block('table_cell_template_join') }} - {{ block('table_cell_template_actions') }} + {% block table_organisations_column_info %} + {% include "tables/columns/organisations-info.html.twig" %} + {% endblock %} + {% block table_organisations_column_description %} + {% include "tables/columns/organisations-description.html.twig" %} + {% endblock %} + {% block table_organisations_column_status %} + {% include "tables/columns/organisations-status.html.twig" %} + {% endblock %} + {% block table_organisations_column_member_count %} + {% include "tables/columns/organisations-member_count.html.twig" %} + {% endblock %} + {% block table_organisations_column_admin_count %} + {% include "tables/columns/organisations-admin_count.html.twig" %} + {% endblock %} + {% block table_organisations_column_join %} + {% include "tables/columns/organisations-join.html.twig" %} + {% endblock %} + {% block table_organisations_column_actions %} + {% include "tables/columns/organisations-actions.html.twig" %} + {% endblock %} {% endblock %} diff --git a/templates/tables/partials/organisation-members/column-actions.html.twig b/templates/tables/partials/organisation-members/column-actions.html.twig deleted file mode 100644 index 5338156..0000000 --- a/templates/tables/partials/organisation-members/column-actions.html.twig +++ /dev/null @@ -1,56 +0,0 @@ -{% block table_cell_template_actions %} -{% if checkAccess('update_organisation_field', { 'organisation': organisation, 'fields': [ 'members' ] }) or isOrganisationAdmin(organisation) %} - -{% endif %} -{% endblock %} \ No newline at end of file diff --git a/templates/tables/partials/organisations/column-actions.html.twig b/templates/tables/partials/organisations/column-actions.html.twig deleted file mode 100644 index 4da90ba..0000000 --- a/templates/tables/partials/organisations/column-actions.html.twig +++ /dev/null @@ -1,86 +0,0 @@ -{% block table_cell_template_actions %} -{%- if hasRole('site-admin') or hasRole('organisations-admin') %} - -{%- elseif (current_user.adminForOrganisations.count > 0) -%} - -{% endif -%} -{% endblock %} \ No newline at end of file diff --git a/templates/tables/partials/organisations/column-admin_count.html.twig b/templates/tables/partials/organisations/column-admin_count.html.twig deleted file mode 100644 index 165899c..0000000 --- a/templates/tables/partials/organisations/column-admin_count.html.twig +++ /dev/null @@ -1,11 +0,0 @@ -{% block table_cell_template_admin_count %} -{%- if checkAccess('view_organisation_members') -%} - -{% endif -%} -{% endblock %} \ No newline at end of file diff --git a/templates/tables/partials/organisations/column-description.html.twig b/templates/tables/partials/organisations/column-description.html.twig deleted file mode 100644 index 6f93bd9..0000000 --- a/templates/tables/partials/organisations/column-description.html.twig +++ /dev/null @@ -1,9 +0,0 @@ -{% block table_cell_template_description %} - -{% endblock %} \ No newline at end of file diff --git a/templates/tables/partials/organisations/column-info.html.twig b/templates/tables/partials/organisations/column-info.html.twig deleted file mode 100644 index c03499a..0000000 --- a/templates/tables/partials/organisations/column-info.html.twig +++ /dev/null @@ -1,19 +0,0 @@ -{% block table_cell_template_info %} - -{% endblock %} \ No newline at end of file diff --git a/templates/tables/partials/organisations/column-join.html.twig b/templates/tables/partials/organisations/column-join.html.twig deleted file mode 100644 index 535369f..0000000 --- a/templates/tables/partials/organisations/column-join.html.twig +++ /dev/null @@ -1,27 +0,0 @@ -{% block table_cell_template_join %} - -{% endblock %} \ No newline at end of file diff --git a/templates/tables/partials/organisations/column-member_count.html.twig b/templates/tables/partials/organisations/column-member_count.html.twig deleted file mode 100644 index 0422aa7..0000000 --- a/templates/tables/partials/organisations/column-member_count.html.twig +++ /dev/null @@ -1,11 +0,0 @@ -{% block table_cell_template_member_count %} -{%- if checkAccess('view_organisation_members') -%} - -{% endif -%} -{% endblock %} \ No newline at end of file diff --git a/templates/tables/partials/organisations/column-status.html.twig b/templates/tables/partials/organisations/column-status.html.twig deleted file mode 100644 index 0521dca..0000000 --- a/templates/tables/partials/organisations/column-status.html.twig +++ /dev/null @@ -1,25 +0,0 @@ -{% block table_cell_template_status %} -{%- if hasRole('site-admin') or hasRole('organisations-admin') or (current_user.adminForOrganisations.count > 0) %} - -{% endif -%} -{% endblock %} \ No newline at end of file diff --git a/templates/tables/users.html.twig b/templates/tables/users.html.twig index 5854c8d..5314164 100644 --- a/templates/tables/users.html.twig +++ b/templates/tables/users.html.twig @@ -1,4 +1,4 @@ -{% extends "@blockier-templates/tables/users.html.twig" %} +{% extends "@uf-tweaks/tables/users.html.twig" %} {% block table %}
{{translate('ORGANISATION')}} {{translate("DESCRIPTION")}} {{translate("DESCRIPTION")}} {{translate("STATUS")}} {{translate("ORGANISATION.MEMBER_COUNT")}} {{translate("ORGANISATION.ADMIN_COUNT")}} {{translate("STATUS")}} {{translate("ORGANISATION.MEMBER_COUNT")}} {{translate("ORGANISATION.ADMIN_COUNT")}} {{translate("JOIN")}}/{{translate("LEAVE")}}{{translate("JOIN")}}/{{translate("LEAVE")}}{{translate("ACTIONS")}}{{translate("ACTIONS")}}
@@ -7,10 +7,10 @@ {% if 'last_activity' in table.columns %} - + {% endif %} {% if 'via_roles' in table.columns %} - + {% endif %} @@ -23,6 +23,8 @@ {% block table_cell_templates %} {{ parent() }} - {{ block('table_cell_template_organisations', 'tables/partials/users/column-organisations.html.twig') }} + {% block table_users_column_organisations %} + {% include 'tables/columns/users-organisations.html.twig' %} + {% endblock %} {% endblock %}
{{translate('USER')}} {{translate("ORGANISATION", 2)}}{{translate("ACTIVITY.LAST")}} {{translate("ACTIVITY.LAST")}} {{translate('PERMISSION.VIA_ROLES')}}{{translate('PERMISSION.VIA_ROLES')}}{{translate("STATUS")}} {{translate("ACTIONS")}}