Naming, layout and comments: descriptive full-word names, one item per line in wrapped calls and literals, and doc comments on exported names

Short and single-letter names in application code become full words (tests
keep theirs). Wrapped calls, signatures and composite literals put one item
per line, and one-line function bodies are expanded. Exported names and
groups of constants get doc comments, and comments refer to the renamed
identifiers.
This commit is contained in:
bwilliams committed 2026-10-15 16:12:56 +01:00
1 parent 043e307663
commit 465358609a
78 files changed
+2374 -1402

No files matched your search

+16 -1
View File
@@ -67,15 +67,20 @@ SELECT t.* FROM opportunities t WHERE t.uuid = ?`
// when the mark is set and is negated with NOT to match it unset; an
// opportunity with no marks row has every mark unset.
const (
// listOpportunitiesSelect selects every opportunity, as t.
listOpportunitiesSelect = `
SELECT t.* FROM opportunities t`
// listOpportunitiesOrderAndPage orders by latest release, newest first,
// and takes a page: the limit and offset arguments.
listOpportunitiesOrderAndPage = `
ORDER BY t.latest_release_date DESC, t.uuid
LIMIT ? OFFSET ?`
// filterOpportunityStatus matches a status.
filterOpportunityStatus = `t.status = ?`
// filterOpportunityClassificationCode matches a classification code.
filterOpportunityClassificationCode = `EXISTS (
SELECT 1
FROM opportunity_classifications tc
@@ -83,35 +88,45 @@ LIMIT ? OFFSET ?`
WHERE tc.opportunity_uuid = t.uuid AND c.code = ?
)`
// The argument must come from ftsQuery, never raw user input.
// filterOpportunityTitleMatch matches a full-text search of the title. The
// argument must come from ftsQuery, never raw user input.
filterOpportunityTitleMatch = `t.id IN (
SELECT rowid FROM opportunities_fts WHERE opportunities_fts MATCH ?
)`
// filterOpportunityReleasedFrom matches a latest release on or after a
// time.
filterOpportunityReleasedFrom = `t.latest_release_date >= ?`
// filterOpportunityReleasedBefore matches a latest release before a time.
filterOpportunityReleasedBefore = `t.latest_release_date < ?`
// filterOpportunityMarkHidden matches the hidden mark set.
filterOpportunityMarkHidden = `EXISTS (
SELECT 1 FROM opportunity_marks m WHERE m.uuid = t.uuid AND m.hidden
)`
// filterOpportunityMarkSkipped matches the skipped mark set.
filterOpportunityMarkSkipped = `EXISTS (
SELECT 1 FROM opportunity_marks m WHERE m.uuid = t.uuid AND m.skipped
)`
// filterOpportunityMarkInterested matches the interested mark set.
filterOpportunityMarkInterested = `EXISTS (
SELECT 1 FROM opportunity_marks m WHERE m.uuid = t.uuid AND m.interested
)`
// filterOpportunityMarkBidSubmitted matches the bid submitted mark set.
filterOpportunityMarkBidSubmitted = `EXISTS (
SELECT 1 FROM opportunity_marks m WHERE m.uuid = t.uuid AND m.bid_submitted
)`
// filterOpportunityMarkWon matches the won mark set.
filterOpportunityMarkWon = `EXISTS (
SELECT 1 FROM opportunity_marks m WHERE m.uuid = t.uuid AND m.won
)`
// filterOpportunityMarkLost matches the lost mark set.
filterOpportunityMarkLost = `EXISTS (
SELECT 1 FROM opportunity_marks m WHERE m.uuid = t.uuid AND m.lost
)`