Files
bwilliams 67215a6aaa Added CODE_CONVENTIONS.md and linters to enforce it, and applied it across the codebase
CODE_CONVENTIONS.md sets out the conventions for Go code in this
repository: naming, layout, comments, errors, logging, configuration and
tests. .golangci.json enables the linters that check the parts that can be
checked (each limited to the rules the conventions use); the rest is
applied by hand.

Applied across the codebase:
- Naming: full-word names in application code, initialisms in one case
  (BuyerID, PrintJSON, PrintYAML, ocdsGetBuyerID), no names shadowing
  built-ins (min/max are minGap/maxGap), mustRaw renamed rawJSON as it
  returns nil rather than panicking, and config.ConfigLevelToLogLevel
  renamed LevelToLogLevel.
- Layout: lines kept to 80 characters where possible, assignments taken
  out of if and for statements that don't fit, wrapped arguments all on
  one line or one per line, steps separated by blank lines, no else after
  a return, function and struct literals wrapped.
- Comments: doc comments on every exported name (including each section's
  Map, Flatten, TypeOf, ValueOf and SetValue), section banners, British
  spelling.
- Errors: a created error starts with its package name, a wrapping error
  adds only what was being done, sentinels in one commented var block,
  errors.Is and errors.As in place of == and type assertions, and no
  err := shadowing of a named result. That fixes the mock server losing
  its access log's close error.
- Logging: the fetcher passes its workers an untagged logger, so
  findatender's lines are tagged with their own component rather than
  with fetcher's as well; cmd/mock-fts logs "stopped" with slog.
- Configuration: util.WithTimeout (moved from the websocket package)
  applies a timeout of 0 or less as no limit, used for the websocket
  write and ping, TCP close and tcpserver shutdown timeouts; every setting
  documents what 0 or empty means, including the rate limit rule's keys
  in internal/config/README.md.
- Tests: related tests merged into table-driven ones with named cases.

Separately from CODE_CONVENTIONS.md, internal/store/README.md gains a soft
SQL style convention for the queries in internal/store/queries.go, and the
queries are reformatted to follow it.
2026-10-15 16:26:42 +01:00

199 lines
4.4 KiB
Go

package store
import (
"context"
"database/sql"
"embed"
"errors"
"fmt"
"io/fs"
"github.com/pressly/goose/v3"
)
// Each file holds both directions, marked with -- +goose Up / -- +goose Down.
// Create new ones with: goose -dir internal/store/migrations create NAME sql
//
//go:embed migrations/*.sql
var migrationsFS embed.FS
// NewMigrator returns a goose Provider over the store's embedded migrations,
// for applying, rolling back or inspecting them. Each migration runs in its
// own transaction, so a failed migration leaves the database at the previous
// version (goose has no "dirty" state).
func NewMigrator(db *sql.DB) (*goose.Provider, error) {
fsys, err := fs.Sub(migrationsFS, "migrations")
if err != nil {
return nil, err
}
return goose.NewProvider(goose.DialectSQLite3, db, fsys)
}
// LatestVersion is the highest migration version in this build.
func LatestVersion(provider *goose.Provider) int64 {
sources := provider.ListSources() // sorted ascending
if len(sources) == 0 {
return 0
}
return sources[len(sources)-1].Version
}
// checkVersion returns ErrNeedsMigration or ErrSchemaTooNew unless the
// database is exactly at this build's schema.
func checkVersion(ctx context.Context, provider *goose.Provider) error {
current, err := provider.GetDBVersion(ctx)
if err != nil {
return err
}
latest := LatestVersion(provider)
if current > latest {
return fmt.Errorf(
"%w (database is at version %d, this build knows up to %d)",
ErrSchemaTooNew,
current,
latest,
)
}
pending, err := provider.HasPending(ctx)
if err != nil {
return err
}
if pending {
return fmt.Errorf(
"%w (database is at version %d, latest is %d)",
ErrNeedsMigration,
current,
latest,
)
}
return nil
}
// checkNotNewer refuses to work on a database migrated by a newer build:
// this build has neither the newer migrations nor their down steps.
func checkNotNewer(ctx context.Context, provider *goose.Provider) error {
current, err := provider.GetDBVersion(ctx)
if err != nil {
return err
}
if latest := LatestVersion(provider); current > latest {
return fmt.Errorf(
"store: database is at version %d but this build only knows up to %d; use a newer build",
current,
latest,
)
}
return nil
}
// prepareSchema migrates (with WithAutoMigrate) or verifies the schema
// version.
func prepareSchema(ctx context.Context, db *sql.DB, opts options) error {
provider, err := NewMigrator(db)
if err != nil {
return err
}
if opts.autoMigrate {
if _, err := provider.Up(ctx); err != nil {
return fmt.Errorf("migrating database: %w", err)
}
}
return checkVersion(ctx, provider)
}
// StepUp applies steps pending migrations, or all of them when steps is 0.
func StepUp(
ctx context.Context, provider *goose.Provider, steps int,
) ([]*goose.MigrationResult, error) {
var results []*goose.MigrationResult
if err := checkNotNewer(ctx, provider); err != nil {
return results, err
}
var err error
if steps == 0 {
results, err = provider.Up(ctx)
} else {
for range steps {
var result *goose.MigrationResult
result, err = provider.UpByOne(ctx)
if errors.Is(err, goose.ErrNoNextVersion) {
err = nil
break
}
if err != nil {
break
}
results = append(results, result)
}
}
return results, err
}
// StepDown rolls back steps applied migrations, or all of them when steps
// is 0. Rolling everything back deletes all data, so confirmDrop is checked
// first in that case.
func StepDown(
ctx context.Context, provider *goose.Provider, steps int, confirmDrop bool,
) ([]*goose.MigrationResult, error) {
var results []*goose.MigrationResult
if err := checkNotNewer(ctx, provider); err != nil {
return results, err
}
current, err := provider.GetDBVersion(ctx)
if err != nil {
return results, err
}
if current == 0 {
return results, nil
}
statuses, err := provider.Status(ctx)
if err != nil {
return results, err
}
applied := 0
for _, status := range statuses {
if status.State == goose.StateApplied {
applied++
}
}
all := steps == 0 || steps >= applied
if all && !confirmDrop {
return results, ErrWouldEmptyDatabase
}
if all {
results, err = provider.DownTo(ctx, 0)
} else {
for range steps {
var result *goose.MigrationResult
result, err = provider.Down(ctx)
if errors.Is(err, goose.ErrNoNextVersion) {
err = nil
break
}
if err != nil {
break
}
results = append(results, result)
}
}
return results, err
}