Files
job-search/internal/websocket/client.go
T
bwilliams 67215a6aaa Added CODE_CONVENTIONS.md and linters to enforce it, and applied it across the codebase
CODE_CONVENTIONS.md sets out the conventions for Go code in this
repository: naming, layout, comments, errors, logging, configuration and
tests. .golangci.json enables the linters that check the parts that can be
checked (each limited to the rules the conventions use); the rest is
applied by hand.

Applied across the codebase:
- Naming: full-word names in application code, initialisms in one case
  (BuyerID, PrintJSON, PrintYAML, ocdsGetBuyerID), no names shadowing
  built-ins (min/max are minGap/maxGap), mustRaw renamed rawJSON as it
  returns nil rather than panicking, and config.ConfigLevelToLogLevel
  renamed LevelToLogLevel.
- Layout: lines kept to 80 characters where possible, assignments taken
  out of if and for statements that don't fit, wrapped arguments all on
  one line or one per line, steps separated by blank lines, no else after
  a return, function and struct literals wrapped.
- Comments: doc comments on every exported name (including each section's
  Map, Flatten, TypeOf, ValueOf and SetValue), section banners, British
  spelling.
- Errors: a created error starts with its package name, a wrapping error
  adds only what was being done, sentinels in one commented var block,
  errors.Is and errors.As in place of == and type assertions, and no
  err := shadowing of a named result. That fixes the mock server losing
  its access log's close error.
- Logging: the fetcher passes its workers an untagged logger, so
  findatender's lines are tagged with their own component rather than
  with fetcher's as well; cmd/mock-fts logs "stopped" with slog.
- Configuration: util.WithTimeout (moved from the websocket package)
  applies a timeout of 0 or less as no limit, used for the websocket
  write and ping, TCP close and tcpserver shutdown timeouts; every setting
  documents what 0 or empty means, including the rate limit rule's keys
  in internal/config/README.md.
- Tests: related tests merged into table-driven ones with named cases.

Separately from CODE_CONVENTIONS.md, internal/store/README.md gains a soft
SQL style convention for the queries in internal/store/queries.go, and the
queries are reformatted to follow it.
2026-10-15 16:26:42 +01:00

307 lines
8.4 KiB
Go

package websocket
import (
"context"
"crypto/rand"
"encoding/json"
"errors"
"log/slog"
"sync"
"sync/atomic"
"time"
"github.com/coder/websocket"
"golang.org/x/time/rate"
"git.avsdev.uk/Go/job-search/internal/util"
)
// clientSendBuffer is how many messages are queued for a client before it
// counts as a slow consumer and is closed.
const clientSendBuffer = 256
// logMessageLimit is how much of a message is logged; longer messages are
// cut short and logged as truncated.
const logMessageLimit = 1 << 10
// msgConn is the connection a client reads and writes messages on: a
// *websocket.Conn, or a tcpConn for plain TCP clients (see tcp.go).
type msgConn interface {
Read(ctx context.Context) (websocket.MessageType, []byte, error)
Write(
ctx context.Context, messageType websocket.MessageType, payload []byte,
) error
Ping(ctx context.Context) error
Close(code websocket.StatusCode, reason string) error
CloseNow() error
}
// client is one connection registered with the hub. Its read loop handles
// incoming envelopes, its write loop sends the queued messages and its ping
// loop checks an idle connection is still alive.
type client struct {
hub *Hub
conn msgConn
send chan []byte // queued messages, sent by writeLoop
id string
ip string
lastSeen atomic.Int64 // unix nanoseconds; set by the read and ping loops
cancel context.CancelFunc
limiter *rate.Limiter // limits the messages the client sends
closeOnce sync.Once
}
// errUnsupportedData is returned by readLoop (and a tcpConn's Write) for a
// binary message.
var errUnsupportedData = errors.New("websocket: binary frames are not supported")
// newClient creates a client for conn. cancel cancels the context the client
// runs with; the client calls it when it finishes or is closed. The client's
// messages are limited by websocket.message_rate_limit if it is enabled.
func newClient(
hub *Hub, conn msgConn, ip string, cancel context.CancelFunc,
) *client {
limiter := rate.NewLimiter(rate.Inf, 0)
if rule := hub.conf.MessageRateLimit; rule.Enabled && rule.PerSecond > 0 {
limiter = rate.NewLimiter(rate.Limit(rule.PerSecond), max(rule.Burst, 1))
}
client := &client{
hub: hub,
conn: conn,
id: rand.Text()[:12],
ip: ip,
send: make(chan []byte, clientSendBuffer),
cancel: cancel,
limiter: limiter,
}
client.lastSeen.Store(time.Now().UnixNano())
return client
}
// run starts the writer and keepalive goroutines and reads until the
// connection ends. It returns once the connection is finished.
func (c *client) run(ctx context.Context) {
var wg sync.WaitGroup
wg.Add(2)
go func() {
defer wg.Done()
c.writeLoop(ctx)
}()
go func() {
defer wg.Done()
c.pingLoop(ctx)
}()
c.sendEnvelope(Envelope{
Type: TypeWelcome,
Payload: rawJSON(map[string]any{
"clientId": c.id,
}),
})
err := c.readLoop(ctx)
switch {
case err == nil:
case websocket.CloseStatus(err) != -1:
// The peer closed the connection, or close() closed it.
case errors.Is(err, errUnsupportedData):
c.close(websocket.StatusUnsupportedData, "text frames only")
case errors.Is(err, context.Canceled):
// The client was cancelled: by close() (shutdown or a slow
// consumer), after a failed write or ping, or by the caller.
c.conn.CloseNow() //nolint:errcheck,gosec // finished with; it may already be closed
default:
c.hub.logger().Debug("read error", "client", c.id, "error", err)
c.conn.CloseNow() //nolint:errcheck,gosec // the connection has failed anyway
}
c.cancel()
wg.Wait()
}
// readLoop reads messages until the connection ends, and returns why.
// Messages over the rate limit or that aren't valid JSON envelopes get an
// error reply; the rest are passed to handle.
func (c *client) readLoop(ctx context.Context) error {
for {
messageType, data, err := c.conn.Read(ctx)
if err != nil {
return err
}
c.logMessage(ctx, "message received", data)
c.lastSeen.Store(time.Now().UnixNano())
if messageType != websocket.MessageText {
return errUnsupportedData
}
// Check if the client is rate limited for early discard
if !c.limiter.Allow() {
c.sendError("", "rate limited")
continue
}
// Unpack the envelope and pass to handle to process if valid
var envelope Envelope
if err := json.Unmarshal(data, &envelope); err != nil {
c.sendError("", "invalid JSON envelope")
continue
}
c.handle(envelope)
}
}
// handle answers one envelope from the client: ping and echo, or an error
// for any other type.
func (c *client) handle(envelope Envelope) {
switch envelope.Type {
case TypePing:
c.sendEnvelope(Envelope{
Type: TypePong,
ID: envelope.ID,
Payload: rawJSON(map[string]any{"time": time.Now().UTC()}),
})
case TypeEcho:
c.sendEnvelope(Envelope{
Type: TypeEcho,
ID: envelope.ID,
Payload: envelope.Payload,
})
default:
c.sendError(envelope.ID, "unknown message type")
}
}
// writeLoop sends queued messages, each within the write timeout (no limit if
// it is 0 or less), until ctx is cancelled. A failed write cancels the client.
func (c *client) writeLoop(ctx context.Context) {
for {
select {
case <-ctx.Done():
return
case msg := <-c.send:
writeCtx, cancel := util.WithTimeout(ctx, c.hub.conf.WriteTimeout)
err := c.conn.Write(writeCtx, websocket.MessageText, msg)
cancel()
if err != nil {
c.hub.logger().Debug("write failed", "client", c.id, "error", err)
c.cancel()
return
}
c.logMessage(ctx, "message sent", msg)
}
}
}
// pingLoop pings the connection when it has been idle for the ping interval;
// no pong within the pong timeout (no limit if it is 0 or less) drops the
// connection. Ping needs the concurrent reader in readLoop to see pongs.
func (c *client) pingLoop(ctx context.Context) {
pingInterval := c.hub.conf.PingInterval
pongTimeout := c.hub.conf.PongTimeout
if pingInterval <= 0 {
return
}
ticker := time.NewTicker(pingInterval)
defer ticker.Stop()
for {
select {
case <-ctx.Done():
return
case <-ticker.C:
// Don't ping if the lastSeen is more recent than the ping interval
lastSeen := time.Unix(0, c.lastSeen.Load())
if time.Now().Before(lastSeen.Add(pingInterval)) {
continue
}
pingCtx, cancel := util.WithTimeout(ctx, pongTimeout)
err := c.conn.Ping(pingCtx)
cancel()
if err != nil {
c.hub.logger().Debug("ping failed", "client", c.id, "error", err)
c.conn.CloseNow() //nolint:errcheck,gosec // dropping the client anyway
c.cancel()
return
}
c.lastSeen.Store(time.Now().UnixNano())
}
}
}
// trySend queues msg without blocking; false means the buffer is full.
func (c *client) trySend(msg []byte) bool {
select {
case c.send <- msg:
return true
default:
return false
}
}
// sendEnvelope queues envelope for the client, closing the client as a slow
// consumer if its queue is full.
func (c *client) sendEnvelope(envelope Envelope) {
encoded, err := json.Marshal(envelope)
if err != nil {
c.hub.logger().Error("marshal", "client", c.id, "error", err)
return
}
if !c.trySend(encoded) {
c.hub.logger().Warn("dropping slow client", "client", c.id, "ip", c.ip)
go c.close(websocket.StatusPolicyViolation, "slow consumer")
}
}
// sendError queues an error envelope replying to the message with id (none
// if empty).
func (c *client) sendError(id, msg string) {
c.sendEnvelope(Envelope{
Type: TypeError,
ID: id,
Error: msg,
})
}
// close performs a graceful close handshake once, then cancels the client.
// It may block for the handshake, so call it from its own goroutine unless
// the read loop has already exited.
func (c *client) close(code websocket.StatusCode, reason string) {
c.closeOnce.Do(func() {
c.conn.Close(code, reason) //nolint:errcheck,gosec // the client is cancelled anyway
c.cancel()
})
}
// logMessage logs a message sent to or received from the client at debug
// level, with its size; at most logMessageLimit bytes of it are logged. It
// does nothing unless debug logging is enabled.
func (c *client) logMessage(ctx context.Context, event string, data []byte) {
logger := c.hub.logger()
if !logger.Enabled(ctx, slog.LevelDebug) {
return
}
logged, truncated := data, false
if len(logged) > logMessageLimit {
logged, truncated = logged[:logMessageLimit], true
}
logger.LogAttrs(
ctx,
slog.LevelDebug,
event, //nolint:sloglint // a constant message from the caller
slog.String("client", c.id),
slog.Int("bytes", len(data)),
slog.String("message", string(logged)),
slog.Bool("truncated", truncated),
)
}