CODE_CONVENTIONS.md sets out the conventions for Go code in this repository: naming, layout, comments, errors, logging, configuration and tests. .golangci.json enables the linters that check the parts that can be checked (each limited to the rules the conventions use); the rest is applied by hand. Applied across the codebase: - Naming: full-word names in application code, initialisms in one case (BuyerID, PrintJSON, PrintYAML, ocdsGetBuyerID), no names shadowing built-ins (min/max are minGap/maxGap), mustRaw renamed rawJSON as it returns nil rather than panicking, and config.ConfigLevelToLogLevel renamed LevelToLogLevel. - Layout: lines kept to 80 characters where possible, assignments taken out of if and for statements that don't fit, wrapped arguments all on one line or one per line, steps separated by blank lines, no else after a return, function and struct literals wrapped. - Comments: doc comments on every exported name (including each section's Map, Flatten, TypeOf, ValueOf and SetValue), section banners, British spelling. - Errors: a created error starts with its package name, a wrapping error adds only what was being done, sentinels in one commented var block, errors.Is and errors.As in place of == and type assertions, and no err := shadowing of a named result. That fixes the mock server losing its access log's close error. - Logging: the fetcher passes its workers an untagged logger, so findatender's lines are tagged with their own component rather than with fetcher's as well; cmd/mock-fts logs "stopped" with slog. - Configuration: util.WithTimeout (moved from the websocket package) applies a timeout of 0 or less as no limit, used for the websocket write and ping, TCP close and tcpserver shutdown timeouts; every setting documents what 0 or empty means, including the rate limit rule's keys in internal/config/README.md. - Tests: related tests merged into table-driven ones with named cases. Separately from CODE_CONVENTIONS.md, internal/store/README.md gains a soft SQL style convention for the queries in internal/store/queries.go, and the queries are reformatted to follow it.
191 lines
4.5 KiB
Go
191 lines
4.5 KiB
Go
package websocket
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"log/slog"
|
|
"sync"
|
|
|
|
ws "github.com/coder/websocket"
|
|
|
|
"git.avsdev.uk/Go/job-search/internal/config"
|
|
)
|
|
|
|
// Hub tracks connected clients, WebSocket (ServeHTTP) and plain TCP
|
|
// (ServeTCP) alike, and sends pushed messages to all of them.
|
|
type Hub struct {
|
|
conf config.JSCServerWebSocket
|
|
log *slog.Logger
|
|
|
|
mu sync.RWMutex
|
|
clients map[*client]struct{}
|
|
closed bool
|
|
wg sync.WaitGroup
|
|
}
|
|
|
|
// defaultMaxMessageSize is the largest message read from a client when
|
|
// max_message_size is not set.
|
|
const defaultMaxMessageSize = 32 << 10
|
|
|
|
// Option configures a Hub.
|
|
type Option func(*Hub)
|
|
|
|
// WithLogger makes the hub log to logger instead of slog.Default().
|
|
func WithLogger(logger *slog.Logger) Option {
|
|
return func(h *Hub) {
|
|
h.log = logger
|
|
}
|
|
}
|
|
|
|
// NewHub creates a hub. It logs to slog.Default() unless given WithLogger.
|
|
func NewHub(conf config.JSCServerWebSocket, opts ...Option) *Hub {
|
|
hub := &Hub{
|
|
conf: conf,
|
|
clients: make(map[*client]struct{}),
|
|
}
|
|
for _, opt := range opts {
|
|
opt(hub)
|
|
}
|
|
return hub
|
|
}
|
|
|
|
// logger returns the logger the hub logs to, tagged with its component.
|
|
func (h *Hub) logger() *slog.Logger {
|
|
log := h.log
|
|
if log == nil {
|
|
log = slog.Default()
|
|
}
|
|
return log.With("component", "ws")
|
|
}
|
|
|
|
// Push sends a message of type msgType to every client. The payload is
|
|
// marshalled once and the same bytes are queued for every client; a client
|
|
// whose queue is full is closed as a slow consumer. A payload that can't be
|
|
// marshalled is logged and nothing is sent.
|
|
func (h *Hub) Push(msgType string, payload any) {
|
|
var rawPayload json.RawMessage
|
|
if payload != nil {
|
|
var err error
|
|
if rawPayload, err = json.Marshal(payload); err != nil {
|
|
h.logger().Error("marshal push payload", "type", msgType, "error", err)
|
|
return
|
|
}
|
|
}
|
|
|
|
msg, err := json.Marshal(Envelope{
|
|
Type: msgType,
|
|
Payload: rawPayload,
|
|
})
|
|
if err != nil {
|
|
h.logger().Error("marshal push", "type", msgType, "error", err)
|
|
return
|
|
}
|
|
|
|
var slow []*client
|
|
h.mu.RLock()
|
|
for client := range h.clients {
|
|
if !client.trySend(msg) {
|
|
slow = append(slow, client)
|
|
}
|
|
}
|
|
h.mu.RUnlock()
|
|
|
|
for _, client := range slow {
|
|
h.logger().Warn(
|
|
"dropping slow client",
|
|
"client", client.id,
|
|
"ip", client.ip,
|
|
)
|
|
go client.close(ws.StatusPolicyViolation, "slow consumer")
|
|
}
|
|
}
|
|
|
|
// Count returns the number of connected clients.
|
|
func (h *Hub) Count() int {
|
|
h.mu.RLock()
|
|
defer h.mu.RUnlock()
|
|
return len(h.clients)
|
|
}
|
|
|
|
// Shutdown closes every connection with 1001 (going away) and waits for the
|
|
// handlers to return. If ctx expires first, the remaining connections are
|
|
// closed at once and ctx's error is returned. New connections are refused
|
|
// afterwards.
|
|
func (h *Hub) Shutdown(ctx context.Context) error {
|
|
h.mu.Lock()
|
|
h.closed = true
|
|
clientShutdowns := make([]*client, 0, len(h.clients))
|
|
for client := range h.clients {
|
|
clientShutdowns = append(clientShutdowns, client)
|
|
}
|
|
h.mu.Unlock()
|
|
|
|
if len(clientShutdowns) == 0 {
|
|
// Nothing to close. Clients that just left are only finishing their
|
|
// unregister, so this wait is short and ctx doesn't apply.
|
|
h.wg.Wait()
|
|
return nil
|
|
}
|
|
|
|
for _, client := range clientShutdowns {
|
|
go client.close(ws.StatusGoingAway, "server shutting down")
|
|
}
|
|
|
|
done := make(chan struct{})
|
|
go func() {
|
|
h.wg.Wait()
|
|
close(done)
|
|
}()
|
|
|
|
select {
|
|
case <-done:
|
|
return nil
|
|
case <-ctx.Done():
|
|
// Both may be ready; a finished shutdown is not a timeout.
|
|
select {
|
|
case <-done:
|
|
return nil
|
|
default:
|
|
}
|
|
for _, client := range clientShutdowns {
|
|
client.conn.CloseNow() //nolint:errcheck,gosec // out of time; dropping it
|
|
}
|
|
return ctx.Err()
|
|
}
|
|
}
|
|
|
|
// maxMessageSize is the largest message read from a client: max_message_size,
|
|
// or defaultMaxMessageSize if that is 0 or less. The configuration rejects -1
|
|
// (no limit) for this setting, as a client could then exhaust the server's
|
|
// memory; a -1 set in code also gets the default, never no limit.
|
|
func (h *Hub) maxMessageSize() int {
|
|
if h.conf.MaxMessageSize <= 0 {
|
|
return defaultMaxMessageSize
|
|
}
|
|
return int(h.conf.MaxMessageSize)
|
|
}
|
|
|
|
// register adds a client to the hub. Hub clients receive all push messages and
|
|
// have their lifecycles tracked by the hub.
|
|
func (h *Hub) register(client *client) bool {
|
|
h.mu.Lock()
|
|
defer h.mu.Unlock()
|
|
|
|
if h.closed {
|
|
return false
|
|
}
|
|
|
|
h.clients[client] = struct{}{}
|
|
h.wg.Add(1)
|
|
|
|
return true
|
|
}
|
|
|
|
// unregister removes a client from the hub.
|
|
func (h *Hub) unregister(client *client) {
|
|
h.mu.Lock()
|
|
delete(h.clients, client)
|
|
h.mu.Unlock()
|
|
h.wg.Done()
|
|
}
|