CODE_CONVENTIONS.md sets out the conventions for Go code in this repository: naming, layout, comments, errors, logging, configuration and tests. .golangci.json enables the linters that check the parts that can be checked (each limited to the rules the conventions use); the rest is applied by hand. Applied across the codebase: - Naming: full-word names in application code, initialisms in one case (BuyerID, PrintJSON, PrintYAML, ocdsGetBuyerID), no names shadowing built-ins (min/max are minGap/maxGap), mustRaw renamed rawJSON as it returns nil rather than panicking, and config.ConfigLevelToLogLevel renamed LevelToLogLevel. - Layout: lines kept to 80 characters where possible, assignments taken out of if and for statements that don't fit, wrapped arguments all on one line or one per line, steps separated by blank lines, no else after a return, function and struct literals wrapped. - Comments: doc comments on every exported name (including each section's Map, Flatten, TypeOf, ValueOf and SetValue), section banners, British spelling. - Errors: a created error starts with its package name, a wrapping error adds only what was being done, sentinels in one commented var block, errors.Is and errors.As in place of == and type assertions, and no err := shadowing of a named result. That fixes the mock server losing its access log's close error. - Logging: the fetcher passes its workers an untagged logger, so findatender's lines are tagged with their own component rather than with fetcher's as well; cmd/mock-fts logs "stopped" with slog. - Configuration: util.WithTimeout (moved from the websocket package) applies a timeout of 0 or less as no limit, used for the websocket write and ping, TCP close and tcpserver shutdown timeouts; every setting documents what 0 or empty means, including the rate limit rule's keys in internal/config/README.md. - Tests: related tests merged into table-driven ones with named cases. Separately from CODE_CONVENTIONS.md, internal/store/README.md gains a soft SQL style convention for the queries in internal/store/queries.go, and the queries are reformatted to follow it.
154 lines
3.8 KiB
Go
154 lines
3.8 KiB
Go
package migrate
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"path/filepath"
|
|
"time"
|
|
|
|
"github.com/pressly/goose/v3"
|
|
"github.com/spf13/cobra"
|
|
|
|
"git.avsdev.uk/Go/job-search/internal/cli"
|
|
"git.avsdev.uk/Go/job-search/internal/store"
|
|
)
|
|
|
|
// openMigrator loads the configuration and returns a migrator over the
|
|
// store's embedded migrations for the configured database, opened with the
|
|
// store's connection settings. The caller must close the returned *sql.DB.
|
|
//
|
|
// If the database file doesn't exist, create decides between asking whether
|
|
// to create it (up) and failing (down, status: nothing to work on).
|
|
func openMigrator(
|
|
cmd *cobra.Command, opts *cli.Options, create, createConfirmed bool,
|
|
) (*goose.Provider, *sql.DB, error) {
|
|
conf, err := opts.RunSetup(cmd, true, true)
|
|
if err != nil {
|
|
return nil, nil, fmt.Errorf("load configuration: %w", err)
|
|
}
|
|
|
|
file := conf.Database.File
|
|
if file == "" {
|
|
return nil, nil, errors.New(
|
|
"no database file specified. Update your configuration",
|
|
)
|
|
}
|
|
|
|
if _, err := os.Stat(file); errors.Is(err, os.ErrNotExist) {
|
|
if !create {
|
|
return nil, nil, fmt.Errorf("database file '%s' does not exist", file)
|
|
}
|
|
if !createConfirmed {
|
|
question := fmt.Sprintf(
|
|
"Database file '%s' does not exist. Would you like to create it?", file,
|
|
)
|
|
if !cli.Confirm(cmd.OutOrStdout(), cmd.InOrStdin(), question) {
|
|
return nil, nil, errors.New("no database file")
|
|
}
|
|
}
|
|
} else if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
db, err := store.OpenDB(file)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
migrator, err := store.NewMigrator(db)
|
|
if err != nil {
|
|
return nil, nil, errors.Join(err, db.Close())
|
|
}
|
|
|
|
return migrator, db, nil
|
|
}
|
|
|
|
// closeDB closes db when deferred, adding any error to *err.
|
|
func closeDB(db *sql.DB, err *error) {
|
|
*err = errors.Join(*err, db.Close())
|
|
}
|
|
|
|
// errWriter writes until a write fails, then keeps the error, so a run of
|
|
// prints needs checking only once.
|
|
type errWriter struct {
|
|
out io.Writer
|
|
err error
|
|
}
|
|
|
|
// printf writes like fmt.Fprintf, unless an earlier write failed.
|
|
func (e *errWriter) printf(format string, args ...any) {
|
|
if e.err == nil {
|
|
_, e.err = fmt.Fprintf(e.out, format, args...)
|
|
}
|
|
}
|
|
|
|
// printResults lists migrations that ran, e.g.
|
|
//
|
|
// applied 00003_create_release_tags_table.sql (2ms)
|
|
func printResults(out io.Writer, results []*goose.MigrationResult) error {
|
|
output := &errWriter{
|
|
out: out,
|
|
}
|
|
for _, result := range results {
|
|
verb := "applied"
|
|
if result.Direction == "down" {
|
|
verb = "reverted"
|
|
}
|
|
output.printf(
|
|
" %-9s %s (%s)\n",
|
|
verb,
|
|
filepath.Base(result.Source.Path),
|
|
result.Duration.Round(time.Millisecond),
|
|
)
|
|
}
|
|
return output.err
|
|
}
|
|
|
|
// failure prints what ran before a failed migration and describes the
|
|
// failure. Each migration runs in a transaction, so the failed one has been
|
|
// rolled back and the database is at the last version that succeeded.
|
|
func failure(out io.Writer, err error) error {
|
|
var partialErr *goose.PartialError
|
|
if !errors.As(err, &partialErr) {
|
|
return err
|
|
}
|
|
|
|
printErr := printResults(out, partialErr.Applied)
|
|
|
|
name := "unknown migration"
|
|
if partialErr.Failed != nil && partialErr.Failed.Source != nil {
|
|
name = filepath.Base(partialErr.Failed.Source.Path)
|
|
}
|
|
|
|
return errors.Join(
|
|
fmt.Errorf(
|
|
"migration %s failed and was rolled back; the database is at the last "+
|
|
"version that succeeded.\nMigration error: %w",
|
|
name,
|
|
partialErr.Err,
|
|
),
|
|
printErr,
|
|
)
|
|
}
|
|
|
|
// printVersion reports where the database ended up.
|
|
func printVersion(
|
|
ctx context.Context, out io.Writer, migrator *goose.Provider,
|
|
) error {
|
|
dbVersion, err := migrator.GetDBVersion(ctx)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if dbVersion == 0 {
|
|
_, err = fmt.Fprintln(out, "Database cleared")
|
|
} else {
|
|
_, err = fmt.Fprintf(out, "Database migrated to version %d\n", dbVersion)
|
|
}
|
|
return err
|
|
}
|