CODE_CONVENTIONS.md sets out the conventions for Go code in this repository: naming, layout, comments, errors, logging, configuration and tests. .golangci.json enables the linters that check the parts that can be checked (each limited to the rules the conventions use); the rest is applied by hand. Applied across the codebase: - Naming: full-word names in application code, initialisms in one case (BuyerID, PrintJSON, PrintYAML, ocdsGetBuyerID), no names shadowing built-ins (min/max are minGap/maxGap), mustRaw renamed rawJSON as it returns nil rather than panicking, and config.ConfigLevelToLogLevel renamed LevelToLogLevel. - Layout: lines kept to 80 characters where possible, assignments taken out of if and for statements that don't fit, wrapped arguments all on one line or one per line, steps separated by blank lines, no else after a return, function and struct literals wrapped. - Comments: doc comments on every exported name (including each section's Map, Flatten, TypeOf, ValueOf and SetValue), section banners, British spelling. - Errors: a created error starts with its package name, a wrapping error adds only what was being done, sentinels in one commented var block, errors.Is and errors.As in place of == and type assertions, and no err := shadowing of a named result. That fixes the mock server losing its access log's close error. - Logging: the fetcher passes its workers an untagged logger, so findatender's lines are tagged with their own component rather than with fetcher's as well; cmd/mock-fts logs "stopped" with slog. - Configuration: util.WithTimeout (moved from the websocket package) applies a timeout of 0 or less as no limit, used for the websocket write and ping, TCP close and tcpserver shutdown timeouts; every setting documents what 0 or empty means, including the rate limit rule's keys in internal/config/README.md. - Tests: related tests merged into table-driven ones with named cases. Separately from CODE_CONVENTIONS.md, internal/store/README.md gains a soft SQL style convention for the queries in internal/store/queries.go, and the queries are reformatted to follow it.
156 lines
4.1 KiB
Go
156 lines
4.1 KiB
Go
package config
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"log/slog"
|
|
"maps"
|
|
"reflect"
|
|
"slices"
|
|
"strings"
|
|
|
|
"github.com/spf13/viper"
|
|
"go.yaml.in/yaml/v3"
|
|
)
|
|
|
|
// EnvPrefix prefixes environment variables that override configuration keys,
|
|
// e.g. JOBSEARCH_LOGGING_LEVEL for logging.level.
|
|
const EnvPrefix string = "JOBSEARCH"
|
|
|
|
// EtcConfigPath is searched for config.* when no config file is given, before
|
|
// the working directory.
|
|
const EtcConfigPath string = "/etc/job-search"
|
|
|
|
// JobSearchConfig is the application's whole configuration, one field per
|
|
// section. Each field's cfg tag must match the section's JSCK* constant.
|
|
type JobSearchConfig struct {
|
|
Database JSCDatabase `cfg:"database"`
|
|
Logging JSCLogging `cfg:"logging"`
|
|
Server JSCServer `cfg:"server"`
|
|
Sources JSCSources `cfg:"sources"`
|
|
}
|
|
|
|
// LoadDefaultConfig sets Viper's defaults from the configuration's default
|
|
// struct tags.
|
|
func LoadDefaultConfig() {
|
|
var conf JobSearchConfig
|
|
if err := applyDefaults(&conf); err != nil {
|
|
panic(fmt.Sprintf("config: %v", err))
|
|
}
|
|
LoadToViper(conf)
|
|
}
|
|
|
|
// ---------- Section methods (see Section) ----------
|
|
|
|
// Map implements Section.
|
|
func (c JobSearchConfig) Map() map[string]any { return mapOf(c) }
|
|
|
|
// Flatten implements Section.
|
|
func (c JobSearchConfig) Flatten() map[string]any { return flattenOf("", c) }
|
|
|
|
// TypeOf implements Section.
|
|
func (c JobSearchConfig) TypeOf(key string) (reflect.Kind, error) {
|
|
return typeOf(c, key)
|
|
}
|
|
|
|
// ValueOf implements Section.
|
|
func (c JobSearchConfig) ValueOf(key string) (any, error) {
|
|
return valueOf(c, key)
|
|
}
|
|
|
|
// SetValue implements Section.
|
|
func (c *JobSearchConfig) SetValue(key string, value any) error {
|
|
return setValue(c, key, value)
|
|
}
|
|
|
|
// LoadFromViper copies every key Viper knows that conf also has into conf.
|
|
// Unknown keys are skipped; invalid values are logged and ignored.
|
|
func LoadFromViper(conf *JobSearchConfig) {
|
|
keys := viper.AllKeys()
|
|
for i := range keys {
|
|
key := keys[i]
|
|
keyType, _ := conf.TypeOf(key)
|
|
if keyType == reflect.Invalid {
|
|
continue
|
|
}
|
|
value, ok := viperValue(key, keyType)
|
|
if !ok {
|
|
slog.Error(
|
|
"unknown config key type",
|
|
"key", key,
|
|
"kind", keyType.String(),
|
|
)
|
|
continue
|
|
}
|
|
if err := conf.SetValue(key, value); err != nil {
|
|
slog.Warn("ignoring invalid config value", "key", key, "error", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// viperValue reads key from Viper as a value of kind. Its bool is false for a
|
|
// kind LoadFromViper doesn't handle.
|
|
func viperValue(key string, kind reflect.Kind) (any, bool) {
|
|
switch kind {
|
|
case reflect.String:
|
|
return viper.GetString(key), true
|
|
case reflect.Int:
|
|
return viper.GetInt(key), true
|
|
case reflect.Bool:
|
|
return viper.GetBool(key), true
|
|
case reflect.Slice:
|
|
// A string, e.g. from an environment variable, is passed on for
|
|
// SetValue to split on commas; GetStringSlice would split it on
|
|
// spaces. A list of objects (a list of sections) is passed on as it
|
|
// is, as GetStringSlice would flatten it.
|
|
switch value := viper.Get(key).(type) {
|
|
case string:
|
|
return value, true
|
|
case []map[string]any: // as LoadToViper sets it
|
|
return value, true
|
|
case []any:
|
|
if len(value) > 0 {
|
|
if _, ok := value[0].(map[string]any); ok {
|
|
return value, true
|
|
}
|
|
}
|
|
}
|
|
return viper.GetStringSlice(key), true
|
|
}
|
|
return nil, false
|
|
}
|
|
|
|
// LoadToViper sets every key of conf as a Viper default.
|
|
func LoadToViper(conf JobSearchConfig) {
|
|
flatMap := conf.Flatten()
|
|
for key := range flatMap {
|
|
viper.SetDefault(key, flatMap[key])
|
|
}
|
|
}
|
|
|
|
// String formats the configuration one "key = value <type>" line per key, with
|
|
// dotted keys, sorted by key.
|
|
func (c JobSearchConfig) String() string {
|
|
var builder strings.Builder
|
|
flat := c.Flatten()
|
|
for _, key := range slices.Sorted(maps.Keys(flat)) {
|
|
kind, _ := c.TypeOf(key)
|
|
fmt.Fprint(&builder, key, " = ", flat[key], " <", kind, ">\n")
|
|
}
|
|
return builder.String()
|
|
}
|
|
|
|
// JSON formats the configuration as indented JSON.
|
|
func (c JobSearchConfig) JSON() string {
|
|
confMap := c.Map()
|
|
encoded, _ := json.MarshalIndent(confMap, "", " ")
|
|
return string(encoded)
|
|
}
|
|
|
|
// YAML formats the configuration as YAML.
|
|
func (c JobSearchConfig) YAML() string {
|
|
confMap := c.Map()
|
|
encoded, _ := yaml.Marshal(confMap)
|
|
return string(encoded)
|
|
}
|